ctactic/aircox-radiocampus
1
0
Fork 0
forked from rc/aircox
Code Issues 10 Pull Requests Activity

code quality

Browse Source
This commit is contained in:
bkfox
2023-03-13 17:47:00 +01:00
parent 934817da8a
commit 112770eddf
162 changed files with 4798 additions and 4069 deletions
Download Patch File Download Diff File Expand all files Collapse all files

101
aircox/views/page.py
View File

@ -1,25 +1,28 @@
from django.http import Http404, HttpResponse
from django.utils.translation import gettext_lazy as _
from django.views.generic import DetailView, ListView
from honeypot.decorators import check_honeypot
from ..filters import PageFilters
from ..forms import CommentForm
from ..models import Category, Comment
from ..models import Comment
from ..utils import Redirect
from .base import BaseView
from .mixins import AttachedToMixin, FiltersMixin, ParentMixin
__all__ = ['BasePageListView', 'BasePageDetailView', 'PageDetailView', 'PageListView']
__all__ = [
"BasePageListView",
"BasePageDetailView",
"PageDetailView",
"PageListView",
]
class BasePageListView(AttachedToMixin, ParentMixin, BaseView, ListView):
""" Base view class for BasePage list. """
template_name = 'aircox/basepage_list.html'
item_template_name = 'aircox/widgets/page_item.html'
"""Base view class for BasePage list."""
template_name = "aircox/basepage_list.html"
item_template_name = "aircox/widgets/page_item.html"
has_sidebar = True
paginate_by = 30
@ -29,35 +32,39 @@ class BasePageListView(AttachedToMixin, ParentMixin, BaseView, ListView):
return super().get(*args, **kwargs)
def get_queryset(self):
return super().get_queryset().select_subclasses().published() \
.select_related('cover')
return (
super()
.get_queryset()
.select_subclasses()
.published()
.select_related("cover")
)
def get_context_data(self, **kwargs):
kwargs.setdefault('item_template_name', self.item_template_name)
kwargs.setdefault('has_headline', self.has_headline)
kwargs.setdefault("item_template_name", self.item_template_name)
kwargs.setdefault("has_headline", self.has_headline)
return super().get_context_data(**kwargs)
class BasePageDetailView(BaseView, DetailView):
""" Base view class for BasePage. """
template_name = 'aircox/basepage_detail.html'
context_object_name = 'page'
"""Base view class for BasePage."""
template_name = "aircox/basepage_detail.html"
context_object_name = "page"
has_filters = False
def get_queryset(self):
return super().get_queryset().select_related('cover')
return super().get_queryset().select_related("cover")
# This should not exists: it allows mapping not published pages
# or it should be only used for trashed pages.
def not_published_redirect(self, page):
"""
When a page is not published, redirect to the returned url instead of an
HTTP 404 code.
"""
"""When a page is not published, redirect to the returned url instead
of an HTTP 404 code."""
return None
def get_object(self):
if getattr(self, 'object', None):
if getattr(self, "object", None):
return self.object
obj = super().get_object()
@ -65,7 +72,7 @@ class BasePageDetailView(BaseView, DetailView):
redirect_url = self.not_published_redirect(obj)
if redirect_url:
raise Redirect(redirect_url)
raise Http404('%s not found' % self.model._meta.verbose_name)
raise Http404("%s not found" % self.model._meta.verbose_name)
return obj
def get_page(self):
@ -73,7 +80,8 @@ class BasePageDetailView(BaseView, DetailView):
class PageListView(FiltersMixin, BasePageListView):
""" Page list view. """
"""Page list view."""
filterset_class = PageFilters
template_name = None
has_filters = True
@ -81,58 +89,65 @@ class PageListView(FiltersMixin, BasePageListView):
filters = None
def get_template_names(self):
return super().get_template_names() + ['aircox/page_list.html']
return super().get_template_names() + ["aircox/page_list.html"]
def get_filterset(self, data, query):
# FIXME: not the most efficient, cause join then split (in django filters)
data['category__id__in'] = ','.join(data.getlist('category__id__in'))
# FIXME: not the most efficient, cause join then split (django filters)
data["category__id__in"] = ",".join(data.getlist("category__id__in"))
return super().get_filterset(data, query)
def get_queryset(self):
qs = super().get_queryset().select_related('category') \
.order_by('-pub_date')
qs = (
super()
.get_queryset()
.select_related("category")
.order_by("-pub_date")
)
return qs
def get_context_data(self, **kwargs):
kwargs['categories'] = self.model.objects.published() \
.filter(category__isnull=False) \
.values_list('category__title', 'category__id') \
.distinct()
kwargs["categories"] = (
self.model.objects.published()
.filter(category__isnull=False)
.values_list("category__title", "category__id")
.distinct()
)
return super().get_context_data(**kwargs)
class PageDetailView(BasePageDetailView):
""" Base view class for pages. """
"""Base view class for pages."""
template_name = None
context_object_name = 'page'
context_object_name = "page"
has_filters = False
def get_template_names(self):
return super().get_template_names() + ['aircox/page_detail.html']
return super().get_template_names() + ["aircox/page_detail.html"]
def get_queryset(self):
return super().get_queryset().select_related('category')
return super().get_queryset().select_related("category")
def get_context_data(self, **kwargs):
if self.object.allow_comments and not 'comment_form' in kwargs:
kwargs['comment_form'] = CommentForm()
kwargs['comments'] = Comment.objects.filter(page=self.object) \
.order_by('-date')
if self.object.allow_comments and "comment_form" not in kwargs:
kwargs["comment_form"] = CommentForm()
kwargs["comments"] = Comment.objects.filter(page=self.object).order_by(
"-date"
)
return super().get_context_data(**kwargs)
@classmethod
def as_view(cls, *args, **kwargs):
view = super(PageDetailView, cls).as_view(*args, **kwargs)
return check_honeypot(view, field_name='website')
return check_honeypot(view, field_name="website")
def post(self, request, *args, **kwargs):
self.object = self.get_object()
if not self.object.allow_comments:
return HttpResponse(_('comments are not allowed'), status=503)
return HttpResponse(_("comments are not allowed"), status=503)
form = CommentForm(request.POST)
comment = form.save(commit=False)
comment.page = self.object
comment.save()
return self.get(request, *args, **kwargs)