code quality

This commit is contained in:
bkfox
2023-03-13 17:47:00 +01:00
parent 934817da8a
commit 112770eddf
162 changed files with 4798 additions and 4069 deletions

View File

@ -1,19 +1,18 @@
from django.views.generic.base import TemplateResponseMixin, ContextMixin
from django.urls import reverse
from django.views.generic.base import ContextMixin, TemplateResponseMixin
from ..models import Page
__all__ = ('BaseView', 'BaseAPIView')
__all__ = ("BaseView", "BaseAPIView")
class BaseView(TemplateResponseMixin, ContextMixin):
has_sidebar = True
""" Show side navigation """
"""Show side navigation."""
has_filters = False
""" Show filters nav """
"""Show filters nav."""
list_count = 5
""" Item count for small lists displayed on page. """
"""Item count for small lists displayed on page."""
@property
def station(self):
@ -23,37 +22,43 @@ class BaseView(TemplateResponseMixin, ContextMixin):
# return super().get_queryset().station(self.station)
def get_sidebar_queryset(self):
""" Return a queryset of items to render on the side nav. """
return Page.objects.select_subclasses().published() \
.order_by('-pub_date')
"""Return a queryset of items to render on the side nav."""
return (
Page.objects.select_subclasses().published().order_by("-pub_date")
)
def get_sidebar_url(self):
return reverse('page-list')
return reverse("page-list")
def get_page(self):
return None
def get_context_data(self, **kwargs):
kwargs.setdefault('station', self.station)
kwargs.setdefault('page', self.get_page())
kwargs.setdefault('has_filters', self.has_filters)
kwargs.setdefault("station", self.station)
kwargs.setdefault("page", self.get_page())
kwargs.setdefault("has_filters", self.has_filters)
has_sidebar = kwargs.setdefault('has_sidebar', self.has_sidebar)
if has_sidebar and 'sidebar_object_list' not in kwargs:
has_sidebar = kwargs.setdefault("has_sidebar", self.has_sidebar)
if has_sidebar and "sidebar_object_list" not in kwargs:
sidebar_object_list = self.get_sidebar_queryset()
if sidebar_object_list is not None:
kwargs['sidebar_object_list'] = sidebar_object_list[:self.list_count]
kwargs['sidebar_list_url'] = self.get_sidebar_url()
kwargs["sidebar_object_list"] = sidebar_object_list[
: self.list_count
]
kwargs["sidebar_list_url"] = self.get_sidebar_url()
if 'audio_streams' not in kwargs:
if "audio_streams" not in kwargs:
streams = self.station.audio_streams
streams = streams and streams.split('\n')
kwargs['audio_streams'] = streams
streams = streams and streams.split("\n")
kwargs["audio_streams"] = streams
if 'model' not in kwargs:
model = getattr(self, 'model', None) or \
hasattr(self, 'object') and type(self.object)
kwargs['model'] = model
if "model" not in kwargs:
model = (
getattr(self, "model", None)
or hasattr(self, "object")
and type(self.object)
)
kwargs["model"] = model
return super().get_context_data(**kwargs)
@ -66,5 +71,3 @@ class BaseAPIView:
def get_queryset(self):
return super().get_queryset().station(self.station)